jocument DDSG features #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
4 times, most recently
from
bec84ed to
f36aeea
Compare
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
from
8511202 to
e22f758
Compare
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
2 times, most recently
from
549a91a to
672e2d8
Compare
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
from
0daaabd to
c97a7eb
Compare
AntonOellerer
commented
Mar 7, 2022
src/main/java/com/docutools/jocument/impl/PlaceholderMapperImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/docutools/jocument/impl/ReflectionResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/docutools/jocument/impl/ReflectionResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/docutools/jocument/impl/ReflectionResolver.java
Outdated
Show resolved
Hide resolved
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
from
a8a637e to
5ae6dde
Compare
betorcs
force-pushed
the
feature/placeholder-mapping
branch
from
f7e1284 to
ae20b83
Compare
To be able to do more complex operations, `CustomPlaceholderResolver` is refactored to also receive the bean of the resolver
…nResolver Before falling back on the mappings for reflection placeholders we first probe if the placeholder name can be directly accessed. If so, we resolve it right away, otherwise we fallback.
Since we are using SXSSF (streamed xssf), it might be that we can only refer to cells which are currently in the buffer and that this implemenation does not work for very large documents.
To be able to deal with `Optional` values, this commit adds the resolving of `Optionals` to jocument, similarly to how `Futures` are resolved.
To be able to resolve properties in optionals in futures, the optional is resolved from the resolved future property
To be able to use the `GenerationOptions` formatting in custom placeholders for resolving single classes, an additional `tryToFormat` method is added, which can be used to format any type.
To be able to translate field values, an annotation is added which marks properties whose value can be translated via the translation functionality in the `GeneratorOptions`.
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
from
61a3f13 to
a2f4003
Compare
Due to recursive parent resolving not existing in the `FutureReflectionResolver`, bugs were uncovered when merging it into the `ReflectionResolver`. To fix this, the logic of when and where mapping and recursing into parents is done has now be changed. Basically, the flow now is * can we resolve? -> if no, map -> can we resolve? -> if no, recurse into the parent quitting if we hit a yes along the way. Additionally, the mapping is checked when trying to resolve conditionals.
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
from
1a435a2 to
1902036
Compare
AntonOellerer
force-pushed
the
feature/placeholder-mapping
branch
from
02b24c7 to
9d930aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the mapping of placeholders and the resolving of futures to be able to interface w/ ddsg internals
Shortcut