Fix xlsx formatting #176
Merged
Fix xlsx formatting #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to simply represent UUIDs, when resolving one, a `ScalarPlaceholder` containing its string representation is returned.
There were a couple of bugs in the xlsx formatting code where style information was copied incorrectly from a row/cell to the new object. Additionally, default column style are now set as well. To verify the behaviour, a test for manual verification has been added to `ExcelDocuments.java`
alexpartsch
approved these changes
Nov 14, 2022
src/main/java/com/docutools/jocument/impl/excel/implementations/SXSSFWriter.java
Show resolved
Hide resolved
AntonOellerer
force-pushed
the
fix/fix-xlsx-formatting-sc-9830
branch
from
9219e11 to
e0cd672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of bugs in the xlsx formatting code where style information was copied incorrectly from a row/cell to the new object.
Additionally, default column style are now set
as well.
To verify the behaviour, a test for manual
verification has been added to
ExcelDocuments.javaShortcut