Extend CustomWordPlaceholderData to insert into header/footer
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, the processing flow when inserting a paragraph into a header or footer lead to a `ClassCastException`, as jocument assumed that the insertion happened into a `XWPFDocument`. To fix this, the abstract method for transforming a placeholder now expects an `IBody` element instead of a `XWPFDocument`, where `IBody` is an interface which describes the possible insertion methods. This allows jocument to insert paragraphs into any kind of xwpf part.
AntonOellerer
force-pushed
the
fix/insert-into-header-footer
branch
from
f3ee686 to
22e62ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the processing flow when inserting a paragraph into a header or footer lead to a
ClassCastException, as jocument assumed that the insertion happened into aXWPFDocument.To fix this, the abstract method for transforming a placeholder now expects an
IBodyelement instead of aXWPFDocument, whereIBodyis an interface which describes the possible insertion methods.This allows jocument to insert paragraphs into any kind of xwpf part.