Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA key 중복 수정입니다. #41

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

owljoa
Copy link
Collaborator

@owljoa owljoa commented Jun 1, 2018

@junbeomlee
어제 말씀하신 rsa public key가 계속 동일했던 부분 수정했습니다.
키 자체 생성은 다르게 되는데 issue #40 에서 제가 말씀드린 public key의 SKI 함수에서 상수 부분 때문에 private key는 달라지는데 public key는 동일했습니다.

public key 부분 SKI 함수의 상수 부분을 public key 인자로 바꿔서 이제 다르게 계산됩니다.

그리고 지금 파일로 저장할땐 (Subject Key Identifier(SKI) + 키 알고리즘 + 키 타입) 형태의 파일명으로 저장하게 되어있는데, SKI는 private key, public key가 동일한게 정상입니다.

@owljoa owljoa requested a review from junbeomlee June 1, 2018 05:29
@owljoa owljoa merged commit 1998b05 into DE-labtory:master Jun 1, 2018
@owljoa owljoa deleted the fix/rsaPubKeySKI branch June 1, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants