Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement vm heap #361

Open
wants to merge 1 commit into
base: 0.2.0
Choose a base branch
from
Open

Implement vm heap #361

wants to merge 1 commit into from

Conversation

AgwaB
Copy link
Collaborator

@AgwaB AgwaB commented Mar 3, 2019 •
edited
Loading

details:

Implement vm heap

  • Test case

hihiboss
hihiboss reviewed Mar 3, 2019
View reviewed changes
Copy link
Member

@hihiboss hihiboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Free() necessary?

vm/heap.go
}
}

func (h *Heap) Set(id Hid, value Hvalue) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Store, not Set?

@junbeomlee
Copy link
Member

How about HAddress, Hdata?

This was referenced Mar 3, 2019
Open
Open
@zeroFruit
Copy link
Member

How about HAddress, Hdata?

HData?

@AgwaB
Copy link
Collaborator Author

AgwaB commented Mar 4, 2019

@hihiboss you mean free method exists to optimize?

@AgwaB
Copy link
Collaborator Author

AgwaB commented Mar 4, 2019

@junbeomlee good!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hihiboss hihiboss hihiboss left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AgwaB @junbeomlee @zeroFruit @hihiboss