Changes in python's random module require a minor change for cxOnePointLeafBiased.
#762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeded choice does reproduce sample(x, 1)[0]. All good. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#733 already exists which is a fix for #732 but the PR is stale as code review changes were not addressed for 6+ months. This is an attempt to fix that. We were experimenting with
deapto understandgpwhich is when we discovered this bug and saw it was already an issue. However before the fix, issue was closed.This PR fixes #732
Please review @cyrilpic @professor @bollwyvl @jmmcd @keszybz @fmder
I didn't know exactly who to tag. That's y I tagged everyone.