Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples are not synchronized #2

Closed
PabRod opened this issue Feb 27, 2024 · 7 comments
Closed

Examples are not synchronized #2

PabRod opened this issue Feb 27, 2024 · 7 comments
Assignees

Comments

@PabRod
Copy link
Contributor

PabRod commented Feb 27, 2024

Problem

If a fresh clone is made and make_examples.jl is run, the following files are updated:

  • examples/Example1.ipynb
  • examples/Example2.ipynb
  • examples/Example2.md

Solution

  • Just update the docs and push them
    • Consider creating a git hook that automates this in the future

In the future we can also consider pushing only the source files, and letting the .md and .ipynb files be generated via a GitHub action.

@SCiarella
Copy link
Member

#3 Modifies make_examples to guarantee a bit more flexibility.

The git hook looks like a fantastic idea, since I think that the use of the .ipynb is only as online documentation, while .jl files are the way to work locally.

@PabRod
Copy link
Contributor Author

PabRod commented Mar 5, 2024

Subtask assigned to Pablo:

  • Create the abovementioned git hook

@luisaforozco
Copy link
Contributor

So we should automate the generation of Example*.ipynb and Example*.md from Example*.jl in a github action.
@PabRod would you like to work on that or assign it to me? Happy with both 😄 but since you are looking at Literate.jl maybe it makes sense that you do it.

@PabRod
Copy link
Contributor Author

PabRod commented Mar 5, 2024

I'll be happy to do it. Thanks!

@PabRod
Copy link
Contributor Author

PabRod commented Mar 14, 2024

The synchronization problem is now fixed. The generation of the docs via a GitHub action is now part of issue #12

@PabRod PabRod closed this as completed Mar 14, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Main Mar 14, 2024
@luisaforozco
Copy link
Contributor

I want to flag that, the automation of the generation os Example*.ipynb and Example*.md from Example*.jl is not mentioned in #12. Can we either keep this issue open or add that to issue #12?

@PabRod
Copy link
Contributor Author

PabRod commented Mar 15, 2024

I am aware. Retrospectivelly, I should have split the task into two: packaging and documenting. Lesson learnt for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants