Implement CNODE training #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @SCiarella ! I was also working on this on my side. I will take a look and also push my branch so that we can compare. |
|
I have the impression that the examples are very complex, with many functions doing various things. Could we maybe keep it a bit simpler? Additionally, I also find some of the Julia syntax rather complex, but this might be only me. I would also say that in the examples, all the functions should be contained in the example notebook/script/md such that you have a clear picture of all elements an can play with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the second part of
Example2, so now it is possible to train the CNODE to learn the Gray-Scott model.I have opened a PR because @luisaforozco started looking at the current main branch that contains some features that have been removed. In particular, to implement the ML training I had to get rid of the following:
Please @luisaforozco merge the PR if you don't have any local conflict!
Disclaimer: the ML is implemented but is extremely slow on my laptop, so I can not confirm yet that it is going to learn the correct thing.