Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 02.04 #23

Merged
merged 25 commits into from
May 7, 2024
Merged

Example 02.04 #23

merged 25 commits into from
May 7, 2024

Conversation

SCiarella
Copy link
Member

This branch will implement Example-02.04.
It will also address #20.

@SCiarella SCiarella marked this pull request as draft March 22, 2024 15:44
@luisaforozco luisaforozco mentioned this pull request Mar 26, 2024
Merged
@SCiarella
Copy link
Member Author

This PR closes #29 because the GPU implementation is required to tackle Example 02.04

SCiarella and others added 17 commits March 27, 2024 16:51
@SCiarella
Attempt to fix GPU
b12299d
@SCiarella
Merge branch 'Example-02.04' of github.com:DEEPDIP-project/CoupledNOD…
565f7af 
…E.jl into Example-02.04
@SCiarella
Make F_u faster on GPU
30eab22
@luisaforozco
Merge remote-tracking branch 'origin/main' into Example-02.04
d6ae07b
@SCiarella
Fix merge main
45f67b5
@luisaforozco
Fix broken links in README.md
24e9742
@luisaforozco
Delete some wrongly commited files and update README.md
bf25d8d
@luisaforozco
Add grid compatibility with Foat32
a69f46b
@luisaforozco
Fix compatibility of loss function in examples.
c2d446d
@luisaforozco
Add FNO to src, ammend dependencies and update example 02.04
4b685a4
@luisaforozco
Add FNO to src, ammend dependencies and update example 02.04
f73fae5
@luisaforozco
Rename LES variables for clarity
20be270
@luisaforozco
Add new Laplacian and check constants use
00b4092
@luisaforozco
Format and add instructions to format manually
e0b6ac2
GPU compatibility
65a4ca1
@luisaforozco
Apply Formater
795a481
@luisaforozco
Updating notebools 02.04
5acc113
@luisaforozco luisaforozco marked this pull request as ready for review April 5, 2024 11:10
@luisaforozco luisaforozco requested a review from APJansen April 5, 2024 11:13
@luisaforozco
Copy link
Contributor

@SCiarella I think we can merge this and in another branch work on the GPU exploration as well as the alternative (potential 02.05)

@SCiarella
Copy link
Member Author

Yes, I agree.
But let's leave #20 open to explore and test the implementation of multishooting in SciML, and also leave #29 open because further testing about the GPU are necessary.

I think that we don't need 02.05 since it was basically a repetition of 02.04 (except that the coarse grid was only for $v$)

@luisaforozco
Copy link
Contributor

Needs to be done: GPU testing.
This version is not working on the GPUs due to memory. We need to handle that better.

@luisaforozco luisaforozco merged commit a8d94f5 into main May 7, 2024
4 checks passed
@luisaforozco luisaforozco deleted the Example-02.04 branch May 24, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APJansen APJansen Awaiting requested review from APJansen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SCiarella @luisaforozco