Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Cleanup #1

wants to merge 13 commits into from

Conversation

APJansen
Copy link

@APJansen APJansen commented Nov 21, 2023

Some basic improvements to usability and readability:

  • Added a Project.toml so that all dependencies can be installed at once (and instructions in the readme)
  • Fixed some warnings that occur once you do this:
    • There needed to be a module wrapping the includes in the main file src/ECNCM_1D.jl
    • There were duplicate includes: in the main file and from one source file to the other
  • Used JuliaFormatter to standardise the formatting
  • Added a workflow to automate this
  • Added a few tests from equations in the paper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant