501233: Switch refresh params to be an object

add some more debugging
DEFRA · Feb 12, 2025 · f3806f2 · f3806f2
1 parent bb4c0de
commit f3806f2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/src/server/common/helpers/auth/refresh-token.js b/src/server/common/helpers/auth/refresh-token.js
@@ -6,21 +6,18 @@ async function refreshAccessToken(request) {
   const refreshToken = authedUser?.refreshToken ?? null
   const azureClientId = config.get('azureClientId')
   const azureClientSecret = config.get('azureClientSecret')
-  const params = new URLSearchParams()
+  const params = {
+    client_id: azureClientId,
+    client_secret: azureClientSecret,
+    grant_type: 'refresh_token',
+    refresh_token: refreshToken,
+    scope: `api://${azureClientId}/cdp.user openid profile email offline_access user.read`
+  }
 
-  params.append('client_id', azureClientId)
-  params.append('client_secret', azureClientSecret)
-  params.append('grant_type', 'refresh_token')
-  params.append('refresh_token', refreshToken)
-  params.append(
-    'scope',
-    `api://${azureClientId}/cdp.user openid profile email offline_access user.read`
-  )
-
-  request.logger.info('Azure OIDC access token expired, refreshing...')
+  request.logger.debug('Azure OIDC access token expired, refreshing...')
 
   return await fetcher(request.server.app.oidc.token_endpoint, {
-    method: 'POST',
+    method: 'post',
     headers: {
       'Content-Type': 'application/x-www-form-urlencoded',
       'Cache-Control': 'no-cache'

diff --git a/src/server/common/helpers/auth/user-session.js b/src/server/common/helpers/auth/user-session.js
@@ -98,7 +98,7 @@ async function updateUserScope(request, userSession) {
  * @returns {Promise<UserSession> | UserSession}
  */
 async function refreshUserSession(request, refreshTokenResponse) {
-  request.logger.debug('User session updating')
+  request.logger.debug({ refreshTokenResponse }, 'User session updating')
 
   /** @type {JwtPayload} */
   const payload = jwt.token.decode(refreshTokenResponse.access_token).decoded