refactor: restructure ahead of adding in multi-species routing. #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename a couple of things to reflect what they're doing, and move some functionality to helpers
aaroncarroll82
changed the title
bendef-24
reviewed
Jan 14, 2025
mattyod
reviewed
Jan 14, 2025
mattyod
reviewed
Jan 14, 2025
mattyod
reviewed
Jan 14, 2025
|
bendef-24
reviewed
Jan 14, 2025
mattyod
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename a couple of things to reflect what they're actually doing.
Move some functionality to helpers (for instance date based functions together, and claim helpers out of the API into a specific helper file)
Added a new couple of routes specifically for MS so we can work on the routing for those separately from the current (pretty baffling) routing that allows different jumps back and forth.