Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFI-1032:Replace good logging with hapi-pino #27

Merged
merged 1 commit into from
Sep 7, 2021
Merged

SFI-1032:Replace good logging with hapi-pino #27

merged 1 commit into from
Sep 7, 2021

Conversation

reddy1praveen
Copy link
Contributor

No description provided.

@reddy1praveen reddy1praveen force-pushed the feature/SFI-1032 branch 2 times, most recently from 98a4135 to eed56a7 Compare September 6, 2021 17:02
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

johnwatson484
johnwatson484 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@johnwatson484 johnwatson484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reddy1praveen reddy1praveen merged commit 22a879b into main Sep 7, 2021
@reddy1praveen reddy1praveen deleted the feature/SFI-1032 branch September 7, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwatson484 johnwatson484 johnwatson484 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reddy1praveen @johnwatson484