Stop logging pool low warnings in the log #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anyone who has had to tail or dig into the [water-abstraction-import](https://github.com/DEFRA/water-abstraction-import) logs will have had to wade through reams of this. ```text 0|import | 2025-01-27T15:30:24.002Z - info: Pool low on connections::Total:20,Idle:0,Waiting:10 0|import | 2025-01-27T15:30:24.002Z - info: Pool low on connections::Total:20,Idle:0,Waiting:9 0|import | 2025-01-27T15:30:24.003Z - info: Pool low on connections::Total:20,Idle:0,Waiting:8 0|import | 2025-01-27T15:30:24.004Z - info: Pool low on connections::Total:20,Idle:0,Waiting:7 0|import | 2025-01-27T15:30:24.004Z - info: Pool low on connections::Total:20,Idle:0,Waiting:6 0|import | 2025-01-27T15:30:24.005Z - info: Pool low on connections::Total:20,Idle:0,Waiting:5 0|import | 2025-01-27T15:30:24.006Z - info: Pool low on connections::Total:20,Idle:0,Waiting:4 0|import | 2025-01-27T15:30:24.006Z - info: Pool low on connections::Total:20,Idle:0,Waiting:3 0|import | 2025-01-27T15:30:24.006Z - info: Pool low on connections::Total:20,Idle:0,Waiting:2 0|import | 2025-01-27T15:30:24.006Z - info: Pool low on connections::Total:20,Idle:0,Waiting:1 0|import | 2025-01-27T15:30:24.007Z - info: Pool low on connections::Total:20,Idle:0,Waiting:5 0|import | 2025-01-27T15:30:24.008Z - info: Pool low on connections::Total:20,Idle:0,Waiting:4 0|import | 2025-01-27T15:30:24.008Z - info: Pool low on connections::Total:20,Idle:0,Waiting:3 0|import | 2025-01-27T15:30:24.009Z - info: Pool low on connections::Total:20,Idle:0,Waiting:2 0|import | 2025-01-27T15:30:24.009Z - info: Pool low on connections::Total:20,Idle:0,Waiting:1 0|import | 2025-01-27T15:30:54.040Z - info: Pool low on connections::Total:20,Idle:0,Waiting:10 0|import | 2025-01-27T15:30:54.040Z - info: Pool low on connections::Total:20,Idle:0,Waiting:9 0|import | 2025-01-27T15:30:54.040Z - info: Pool low on connections::Total:20,Idle:0,Waiting:8 0|import | 2025-01-27T15:30:54.041Z - info: Pool low on connections::Total:20,Idle:0,Waiting:7 0|import | 2025-01-27T15:30:54.042Z - info: Pool low on connections::Total:20,Idle:0,Waiting:6 0|import | 2025-01-27T15:30:54.042Z - info: Pool low on connections::Total:20,Idle:0,Waiting:5 0|import | 2025-01-27T15:30:54.042Z - info: Pool low on connections::Total:20,Idle:0,Waiting:4 0|import | 2025-01-27T15:30:54.043Z - info: Pool low on connections::Total:20,Idle:0,Waiting:3 0|import | 2025-01-27T15:30:54.043Z - info: Pool low on connections::Total:20,Idle:0,Waiting:2 0|import | 2025-01-27T15:30:54.043Z - info: Pool low on connections::Total:20,Idle:0,Waiting:1 ``` Each night, this makes thousands of appearances in the logs. At this time we don't have the capacity of rebuilding _how_ they have made their connection to the DB. But we can certainly stop this message from appearing and swamping the actual entries we want to see.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone who has had to tail or dig into the water-abstraction-import logs will have had to wade through reams of this.
Each night, this makes thousands of appearances in the logs. At this time, we don't have the capacity to rebuild how they have made their connection to the DB. But we can stop this message from appearing and swamping the entries we want to see.