Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create postgres pool factory #82

Merged
merged 4 commits into from
Dec 19, 2019
Merged

Create postgres pool factory #82

merged 4 commits into from
Dec 19, 2019

Conversation

james-siteclick
Copy link
Contributor

@james-siteclick james-siteclick commented Dec 18, 2019

Moves database connector code to the helpers so it can be easily shared between projects.
Adds logging for errors and pool low on connections.

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #82 into master will increase coverage by 0.03%.
The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   97.55%   97.58%   +0.03%     
==========================================
  Files          21       22       +1     
  Lines         940      994      +54     
==========================================
+ Hits          917      970      +53     
- Misses         23       24       +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/db/index.js 98.11% <98.07%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e43380...e8ceed2. Read the comment docs.

@swaff swaff merged commit 3a5de01 into master Dec 19, 2019
@swaff swaff deleted the chore/WATER-2454-pool branch December 19, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants