Skip to content

Commit

Permalink
Fix missing Objection Id columns
Browse files Browse the repository at this point in the history
It was spotted whilst working on [Update "create bill run" endpoint to create a bill run](#56) that we had an issue with our [Objection models](https://vincit.github.io/objection.js/).

The previous team didn't use the convention of just calling the unique identifier in each table `id`. Instead they incorporate the table name, for example, `billing_batch_id`. **Objection** is expecting the identifier column to be `id` and is failing when in some cases.

Because of this we need to go back and specify [idColumn](https://vincit.github.io/objection.js/api/model/static-properties.html#static-idcolumn) in all our models.
  • Loading branch information
Cruikshanks committed Dec 16, 2022
1 parent 83e6266 commit fd83625
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit fd83625

Please sign in to comment.