Add sentence case function & rename capitalize #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4315 As part of work to re-create the communications tab in the view licence page we needed to display some text from the DB in [Sentence case](https://titlecaseconverter.com/blog/sentence-case-vs-title-case/). At the same time we also needed to capitalize the first character of a word. The superstar @jonathangoulding solved both these problems in their change. But wait! We already have a `capitalize()` method in the base presenter. We were ready to suggest the change when we realised it wouldn't solve the sentence case issue. Eeek! We need to keep the sentence case solution but it relies on the title case method @jonathangoulding added. This change is to sort things out so we can solve the problems in that change. Our reasoning is that if we have a `sentenceCase()` solution its ideal home is with similar functions in the base presenter. But it also highlighted the world refers to what we are currently doing in `capitalize()` as title case. So, we rename it as part of the change.
Also rename the variable used in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4315
As part of our work to re-create the communications tab in the view licence page, we needed to display some text from the DB in Sentence case. At the same time, we also needed to capitalize the first character of a word. The superstar @jonathangoulding solved both of these problems in their change.
But wait! We already have a
capitalize()method in the base presenter. We were ready to suggest the change when we realised it wouldn't solve the sentence case issue.Eeek! We need to keep the sentence case solution, but it relies on the title case method @jonathangoulding added.
This change is to sort things out so we can solve the problems in that change. Our reasoning is that if we have a
sentenceCase()solution, its ideal home is with similar functions in the base presenter. But it also highlighted that the world refers to what we are currently doing incapitalize()as 'title case'.So, we rename it as part of this change.