Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content change on set adjustment factors page 2pt #1041

Merged
merged 2 commits into from
May 21, 2024

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/browse/WATER-4439

During the testing for the above ticket, it was decided that a content change was necessary on the set adjustment factors page. This PR is removing the 'optional' text from the page. The PR is also fixing a small bug, where if a user enters 0 for the adjustment factors (unlikely) the 0 will not appear pre-populated on the input boxes if they were to go back to the page again.

https://eaflood.atlassian.net/browse/WATER-4439

During the testing for the above ticket it was decided that a content change was necessary on the set adjustment factors page. This PR is removing the 'optional' text from the page. The PR is also fixing a small bug, where if a user enters 0 for the adjustment factors (unlikely) that the 0 will appear pre populated on the input boxes if they were to go back to the page again (it currently is not populating the boxes with a 0).
@Beckyrose200 Beckyrose200 added the enhancement New feature or request label May 21, 2024
@Beckyrose200 Beckyrose200 self-assigned this May 21, 2024
@Beckyrose200 Beckyrose200 marked this pull request as ready for review May 21, 2024 10:18
Copy link
Contributor

@rvsiyad rvsiyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beckyrose200 Beckyrose200 merged commit 49ac3a3 into main May 21, 2024
6 checks passed
@Beckyrose200 Beckyrose200 deleted the alter-set-adjustment-page branch May 21, 2024 11:32
Demwunz pushed a commit that referenced this pull request May 23, 2024
https://eaflood.atlassian.net/browse/WATER-4439

During the testing for the above ticket, it was decided that a content change was necessary on the set adjustment factors page. This PR is removing the 'optional' text from the page. The PR is also fixing a small bug, where if a user enters 0 for the adjustment factors (unlikely) the 0 will not appear pre-populated on the input boxes if they were to go back to the page again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants