Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature returns required purposes #1064

Merged
merged 37 commits into from
Jun 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
53bed41
Check your requirements - purposes
jonathangoulding May 31, 2024
0f571f1
test: update check service test output
jonathangoulding May 31, 2024
6a40821
chore: nit
jonathangoulding May 31, 2024
8597ed4
fix: syntax
jonathangoulding Jun 3, 2024
845e102
fix: unknown span
jonathangoulding Jun 3, 2024
df1172d
Merge branch 'main' into feature-returns-required-purposes
jonathangoulding Jun 3, 2024
867ae43
feat: move Remove requirement button into card
jonathangoulding Jun 3, 2024
f33c637
test: return requirements
jonathangoulding Jun 3, 2024
305f761
Merge branch 'main' into feature-returns-required-purposes
jonathangoulding Jun 3, 2024
ec9e956
fix: alpha
jonathangoulding Jun 3, 2024
d08e418
fix: alpha case in file path
jonathangoulding Jun 3, 2024
387c05c
Merge branch 'main' into feature-returns-required-purposes
jonathangoulding Jun 4, 2024
7b88424
fix: use session, remove necessary query
jonathangoulding Jun 4, 2024
34e31c4
chore: nit alpha
jonathangoulding Jun 4, 2024
a3d2389
chore: nit alpha purpose funcs
jonathangoulding Jun 4, 2024
5b62b35
chore: fix njk format
jonathangoulding Jun 4, 2024
7e34783
chore: fix njk format
jonathangoulding Jun 4, 2024
e175afe
chore: fix njk format
jonathangoulding Jun 4, 2024
177110c
chore: fix njk format
jonathangoulding Jun 4, 2024
803c14b
chore: fix comment
jonathangoulding Jun 4, 2024
fbc6ba4
fix: conditional render
jonathangoulding Jun 4, 2024
62fff11
Update returns-requirements.presenter.js
jonathangoulding Jun 4, 2024
3402ecf
Update returns-requirements.presenter.js
jonathangoulding Jun 4, 2024
e22f6e7
Update returns-requirements.service.js
jonathangoulding Jun 4, 2024
e98c03c
Update returns-requirements.service.js
jonathangoulding Jun 4, 2024
db156b1
Update returns-requirements.presenter.test.js
jonathangoulding Jun 4, 2024
149c4e9
Update returns-requirements.presenter.test.js
jonathangoulding Jun 4, 2024
a9e9429
fix: njk html to text
jonathangoulding Jun 4, 2024
8fb2c2b
fix: use of purposes over purposeIds
jonathangoulding Jun 4, 2024
874bd6f
chore: updated jsdocs
jonathangoulding Jun 4, 2024
aa5d677
test: update purpose test structure
jonathangoulding Jun 4, 2024
ae443c7
Update app/presenters/return-requirements/check/returns-requirements.…
jonathangoulding Jun 4, 2024
0a901b8
Update app/services/return-requirements/check/returns-requirements.se…
jonathangoulding Jun 4, 2024
aa08920
Update app/presenters/return-requirements/check/returns-requirements.…
jonathangoulding Jun 4, 2024
b8a43e0
Update app/services/return-requirements/check/returns-requirements.se…
jonathangoulding Jun 4, 2024
678fa8c
Update app/presenters/return-requirements/check/returns-requirements.…
jonathangoulding Jun 4, 2024
5223f13
fix: spans for test
jonathangoulding Jun 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: njk html to text
jonathangoulding committed Jun 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit a9e9429c999c15aee9d960b5cf478185de46fbea
4 changes: 2 additions & 2 deletions app/views/return-requirements/check.njk
jonathangoulding marked this conversation as resolved.
Show resolved Hide resolved
Cruikshanks marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@
text: "Start date"
},
value: {
html: '<span data-test="meta-data-start-date">' + startDate + '</span>'
text: startDate
},
actions: {
items: [
@@ -55,7 +55,7 @@
text: "Reason"
},
value: {
html: '<span data-test="meta-data-reason">' + reason + '</span>'
text: reason
},
jonathangoulding marked this conversation as resolved.
Show resolved Hide resolved
actions: {
items: [