Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Return Requirement helpers to data loader #1109

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/WATER-4283

When we added the return requirement models as part of our work to switch managing them in NALD to WRLS, we forgot to add them to the data load service, which we use for acceptance testing. Makes it hard to write acceptance tests for return requirements! 🤦

This change corrects that omission.

https://eaflood.atlassian.net/browse/WATER-4283

When we added the return requirement models as part of our work to switch managing them in NALD to WRLS, we forgot to add them to the data load service, which we use for acceptance testing. Makes it hard to write acceptance tests for return requirements! 🤦

This change corrects that omission.
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label Jun 16, 2024
@Cruikshanks Cruikshanks self-assigned this Jun 16, 2024
@Cruikshanks Cruikshanks marked this pull request as ready for review June 16, 2024 10:24
@Cruikshanks Cruikshanks merged commit 12af920 into main Jun 16, 2024
6 checks passed
@Cruikshanks Cruikshanks deleted the add-missed-helpers-to-loader branch June 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant