Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message text in two-part tariff review screen #1116

Merged
merged 4 commits into from
Jun 18, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix message text in two-part tariff review screen
On the Review screen when there are licences in review we show a message letting users know how many there are. Currently when there is only 1 licence in review the text displays as `1 licences` whereas it should be singular and display `1 licence`.

This PR corrects that text.
Jozzey committed Jun 18, 2024
commit 1d86e53e87978e2205d4d414d154f5b3708670bf
28 changes: 15 additions & 13 deletions app/views/bill-runs/review.njk
Original file line number Diff line number Diff line change
@@ -101,19 +101,21 @@
</div>

{# Dynamic message either telling the user they have issues to deal with or that they can generate bills #}
{% if numberOfLicencesToReview > 0 %}
<section class="govuk-!-margin-bottom-9">
{{ govukInsetText({
html: '<span data-test="licences-to-review">You need to review ' + numberOfLicencesToReview + ' licences with returns data issues. You can then continue and send the bill run.</span>'
}) }}
</section>
{% else %}
<section class="govuk-!-margin-bottom-9">
{{ govukInsetText({
html: '<span data-test="licences-to-review">You have resolved all returns data issues. Continue to generate bills.</span>'
}) }}
</section>
{% endif %}
<section class="govuk-!-margin-bottom-9">
{% if numberOfLicencesToReview === 1 %}
{{ govukInsetText({
html: '<span data-test="licences-to-review">You need to review ' + numberOfLicencesToReview + ' licence with returns data issues. You can then continue and send the bill run.</span>'
}) }}
{% elif numberOfLicencesToReview > 1 %}
{{ govukInsetText({
html: '<span data-test="licences-to-review">You need to review ' + numberOfLicencesToReview + ' licences with returns data issues. You can then continue and send the bill run.</span>'
}) }}
{% else %}
{{ govukInsetText({
html: '<span data-test="licences-to-review">You have resolved all returns data issues. Continue to generate bills.</span>'
}) }}
{% endif %}
</section>

{# Cancel bill run button #}
<section class="govuk-!-margin-bottom-9">