Generate Billing Invoice Licence record for SROC #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3897 In order to 'piggy-back' onto the existing functions in the legacy service for reviewing, confirming, sending, viewing, deleting a bill run etc we need to create the same base database records as it does for a Bill run.' We already have billing_batches and events and are working on the billing_transactions in https://eaflood.atlassian.net/browse/WATER-3895 and https://eaflood.atlassian.net/browse/WATER-3894 We are also planning on building the billing_invoice record in https://eaflood.atlassian.net/browse/WATER-3896 So, the next entity we need is the billing_invoice_licence. This is the link between the billing_batch, the invoice account, and from there to the transactions to be included in the bill run. We'll need to dig into the legacy code to understand where the previous team extracts the data that forms the billing_invoice_licence records.
Cruikshanks
requested changes
Feb 20, 2023
test/services/supplementary-billing/create-billing-invoice-licence.service.test.js
Outdated
Show resolved
Hide resolved
…ence.service.test.js Co-authored-by: Alan Cruikshanks <alan.cruikshanks@gmail.com>
Cruikshanks
approved these changes
Feb 20, 2023
Jozzey
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3897
In order to 'piggy-back' onto the existing functions in the legacy service for reviewing, confirming, sending, viewing, deleting a bill run etc we need to create the same base database records as it does for a Bill run. As part of this we need to generate
billing_invoice_licenceentities, which link billing invoices with licences. We already have this entity so this PR implementsCreateBillingInvoiceLicenceServicewhich can create these.