Create return logs for newly imported licences #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/water-abstraction-system into create-return-logs-for-new-licence
…/water-abstraction-system into create-return-logs-for-new-licence
jonathangoulding
added a commit
that referenced
this pull request
Sep 10, 2024
https://eaflood.atlassian.net/browse/WATER-4545 Relevant changes - #1294 As part of the ongoing work to migrate the legacy import jobs we need to establish if a licence already exists in the wrls database. We check if the licence already exists, if it does then we want to do nothing. If it does not exist we want to generate return logs. This change is added to highlight where we need to add this additional logic. And the service call will be added in another piece of work.
…/water-abstraction-system into create-return-logs-for-new-licence
…/water-abstraction-system into create-return-logs-for-new-licence
Cruikshanks
requested changes
Sep 16, 2024
app/services/jobs/return-logs/fetch-licence-return-requirements.service.js
Outdated
Show resolved
Hide resolved
app/services/jobs/return-logs/fetch-licence-return-requirements.service.js
Outdated
Show resolved
Hide resolved
app/services/jobs/return-logs/fetch-return-requirements.service.js
Outdated
Show resolved
Hide resolved
app/services/jobs/return-logs/fetch-return-requirements.service.js
Outdated
Show resolved
Hide resolved
Cruikshanks
requested changes
Sep 17, 2024
test/services/jobs/return-logs/process-licence-return-logs.service.test.js
Outdated
Show resolved
Hide resolved
test/services/jobs/return-logs/process-licence-return-logs.service.test.js
Outdated
Show resolved
Hide resolved
…/water-abstraction-system into create-return-logs-for-new-licence
Cruikshanks
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4545
As part of the work to replace the legacy system NALD we need to generate return logs. This PR updates the logic of return log creation to allow for new licences to be imported and have their return logs created