Fix incorrect edit link for void returns #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4661 Our users have spotted that we are providing a link for `VOID` returns in the view licence page that takes users to the returns edit page. Users should not be able to edit a `VOID` return and unfortunately there is nothing in the legacy edit page to stop this. So, we need to fix the link to take users to view returns page, not edit.
Use a function which is our convention for larger data sets. Plus update the date to use realistic ID's (return logs don't use GUIDs).
Before we start making changes to the presenter we want to ensure we have proper coverage of everything it is doing now. One thing it has highlighted is that we are marking overdue a return that is due 'today'. This is because when we generate the variable `today` in the presenter we are not discarding the time. So, for example, if the return is due 2024-09-05 and the date is the same, when we do the comparison we are actually doing `2024-09-05 00:00:00 < 2024-09-05 13:27:56`. This means it display as "overdue" when in fact it should be "due" (confirmed by comparing to the legacy version of the returns tab).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4661
Our users have noticed that we provide a link for
VOIDreturns on the view licence page that takes them to the returns edit page. Users should not be able to edit aVOIDreturn; unfortunately, there is nothing on the legacy edit page to stop this.So, we need to fix the link to take users to view returns page, not edit.
While working on this, we also found that the status was showing return logs due 'today' incorrectly (they were showing as "overdue" when the status should be "due").