Fix show unregistered label in view licence page #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4683 It has been spotted when a licence has a registered user, in some case we are still displaying 'Unregistered licence' as the sub-heading above the title. We've tracked it down to licences that have a registered user, but where an alias for the licence has not been added. We're not handling that scenario so falling back to displaying 'Unregistered licence'. The fix is just to leave it blank.
Cruikshanks
requested review from
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4683
It has been spotted that when a licence has a registered user, we sometimes display 'Unregistered licence' as the subheading above the title.
We've tracked it down to licences with a registered user, but no alias was added. We're not handling that scenario, so we're falling back on displaying 'Unregistered licence'.
The fix is to leave it blank.
Before fix
After fix