Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 2PT match and allocate logic to own folder #1471

Merged
merged 10 commits into from
Nov 10, 2024

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/WATER-4739

Following on from our work in Tidy up two-part tariff review code and routes, this change moves the two-part tariff match and allocate logic into its own folder. This will hopefully help us distinguish what aspect of the two-part tariff engine a module relates to.

Unlike the previous change, though, we're having to ignore any issues or ways to clean things up. Time is not on our side! So, it's just moving the modules.

https://eaflood.atlassian.net/browse/WATER-4739

Following on from our work in [Tidy up two-part tariff review code and routes](#1443) this change moves the two-part tariff match & allocate logic into it's own folder. This will hopefully help us distinguish what aspect of two-part tariff a module relates to.

Unlike the previous change though, we're having to turn a blind eye to any issues or ways we can clean things up. Time is not on our side! So, it's just moving the modules.
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label Nov 9, 2024
@Cruikshanks Cruikshanks self-assigned this Nov 9, 2024
@Cruikshanks Cruikshanks marked this pull request as ready for review November 10, 2024 12:10
@Cruikshanks Cruikshanks merged commit 1bb1202 into main Nov 10, 2024
5 of 6 checks passed
@Cruikshanks Cruikshanks deleted the move-2pt-allocate-logic branch November 10, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant