Refactor existing supplementary billing flags service #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/jira/software/c/projects/WATER/boards/96 As part of our efforts to clean up the legacy code base and ensure that our existing functionality is working, we have been refactoring and migrating the logic for supplementary billing flags. This PR is focused on migrating the mechanism for flagging a licence when it is removed from a bill run in a ready status.
Beckyrose200
added
the
housekeeping
Beckyrose200
force-pushed
the
refactor-remove-bill-licence-flags
branch
from
3abbcb6 to
89c08a7
Compare
Beckyrose200
changed the title
StuAA78
requested changes
Nov 18, 2024
app/services/licences/supplementary/determine-charge-version-flags.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/supplementary/determine-workflow-flags.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/supplementary/determine-return-log-flags.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/supplementary/process-billing-flag.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/supplementary/determine-charge-version-flags.service.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4746
As part of our efforts to clean up the legacy code base and ensure that our existing functionality is working, we have been refactoring and migrating the logic for supplementary billing flags.
This PR focuses on refactoring the existing legacy code to handle flagging for all three types (pre-sroc, sroc and two-part tariff).