Add determine bill licence flags service #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4746 This PR contributes to cleaning up the supplementary billing flagging process, specifically focusing on handling licences removed from a bill run. When a bill run is created, users can remove licences from it. Depending on the type of bill run, the following actions are required: Annual Bill Run: The licence must be flagged for inclusion in the next supplementary bill run. Supplementary Bill Run: Since the licence was already flagged (which is why it was included in this bill run), the existing flag must be maintained. This logic is managed by the DetermineBillLicenceService. Previously, flagging logic for licences was handled entirely in legacy code. While the endpoint in the service repository still processes other aspects of licence removal, the flagging logic has been moved to our new ProcessBillingFlagsService. This service ensures flags are correctly determined before the legacy endpoint is called.
Beckyrose200
added
the
housekeeping
…Flags service and test
|
Prettified! |
Jozzey
reviewed
Nov 27, 2024
app/services/licences/supplementary/determine-bill-licence-flags.service.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4746
This PR contributes to cleaning up the supplementary billing flagging process, specifically focusing on handling licences removed from a bill run.
When a bill run is created, users can remove licences from it. Depending on the type of bill run, the following actions are required:
Annual Bill Run: The licence must be flagged for inclusion in the next supplementary bill run. Supplementary Bill Run: Since the licence was already flagged (which is why it was included in this bill run), the existing flag must be maintained. This logic is managed by the DetermineBillLicenceService.
Previously, flagging logic for licences was handled entirely in legacy code. While the endpoint in the service repository still processes other aspects of licence removal, the flagging logic has been moved to our new ProcessBillingFlagsService. This service ensures flags are correctly determined before the legacy endpoint is called.