Fix sonarcloud test coverage reporting #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run our tests locally 94.24% is reported. However, sonarcloud is reporting 97.3%. We never understood this discrepancy in the SROC team. But when we came to WATER we were finally able to track it down to how things were configired in `sonar-project.properties`. This change updates the file to bring in what we learnt and applied to our other **water-abstraction** projects.
|
TBH it's still not exactly matching. But it is closer and at least consistent with the other projects 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run our tests locally 94.24% is reported. However, SonarCloud is reporting 97.3%. We never understood this discrepancy in the SROC team. But when we came to WATER we were finally able to track it down to how things were configured in
sonar-project.properties.This change updates the file to bring in what we learnt and applied to our other water-abstraction projects.