Update licences response in supplementary #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3787 As part of our first pass of getting the supplementary process kicked off and working we are just trying to ensure that the records we are working with match the acceptance criteria of the tickets the team have created. The acceptance criteria for WATER-3787 is all licences flagged for supplementary billing for a selected region. At the moment the licence results we returned are generated by extracting the unique licence references from our charge versions results. This means we're only showing licences after an additional filter has been applied. Currently this is only for testing purposes so there is no fear of what we are doing making the final version. But to better align with the ticket and its acceptance criteria, this change updates the supplementary service to return a seperate licences result.
Make it consistent with our other services
We're going to update it to use the model. So, we want some tests first to confirm we don't break anything.
It just makes it easier to manage passing around the region object as opposed to just the NALD region ID, or the Region ID itself.
Both are now working together to deliver the response we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3787
As part of our first pass at getting the supplementary process kicked off and working, we are just trying to ensure that the records we are working with match the acceptance criteria of the tickets the team have created.
The acceptance criteria for WATER-3787 is all licences flagged for supplementary billing for a selected region. At the moment the licence results we returned are generated by extracting the unique licence references from our charge versions results. This means we're only showing licences after an additional filter has been applied.
Currently, this is only for testing purposes so there is no fear of what we are doing making the final version. But to better align with the ticket and its acceptance criteria, this change updates the supplementary service to return a separate 'licences' result.