Remove reporting from /health/info #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
Jozzey
requested changes
Nov 14, 2023
https://eaflood.atlassian.net/browse/WATER-4169 3 charging forecast reports were built by the previous dev team. They are accessed from a link on the manage page in the internal UI. They have never been used because they were identified as returning incorrect values and have never been fixed for 'reasons'. They will now never be fixed because all reporting work is being handled by our partnership with RDP and RSP. This means [water-abstraction-reporting](https://github.com/DEFRA/water-abstraction-reporting) is a defunct app we can remove from the service. One of the first steps to allow this to happen is for the `/health/info` page which we use to check the health of the service to stopping pinging reporting. This change removes that check plus any associated config which was needed to support it.
Cruikshanks
force-pushed
the
remove-reporting-from-service-status
branch
from
ab0855e to
373be97
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4169
Three charging forecast reports were built by the previous dev team. They are accessed from a link on the manage page in the internal UI. They have never been used because they were identified as returning incorrect values and have never been fixed for 'reasons'. They will never be fixed because all reporting work is being handled by our partnership with RDP and RSP.
This means water-abstraction-reporting is a defunct app we can remove from the service. One of the first steps to allow this to happen is for the
/health/infopage which we use to check the health of the service to stop pinging reporting.This change removes that check plus any associated config which was needed to support it.