Rename custom SCSS class #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4131 When working on [Fix display of credit transactions in bill views](#522) after adding the missing `-` to credit values we found the UI was wrapping it _after_ the sign, for example ``` - £126.74 ``` We knew we could fix this by updating the CSS for the class to include `white-space: nowrap;`. The issue was where do we add it. We wasted a bunch of time trying to find the class `govuk-table__cell--total` in the design system code. Finally, we tracked it now to a custom class we'd added. This change is about not making that mistake again and trying to set a precedent. From now on, if we have to add out own custom class we should ***not*** prefix it with `govuk` so we can distinguish between our own code and that provided by GDS.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4131
When working on Fix display of credit transactions in bill views after adding the missing
-to credit values we found the UI was wrapping it after the sign, for exampleWe knew we could fix this by updating the CSS for the class to include
white-space: nowrap;. The issue was where do we add it. We wasted a bunch of time trying to find the classgovuk-table__cell--totalin the design system code. Finally, we tracked it now to a custom class we'd added.This change is about not making that mistake again and trying to set a precedent. From now on, if we have to add a custom class we should not prefix it with
govukso we can distinguish between our code and that provided by GDS.