Build models for returns based on new Views
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#106 As part of the work we have been doing to get migrations working in [water-abstraction-system](https://github.com/DEFRA/water-abstraction-system) we are going to be creating all our new tables in a single schema `public`. We have also decided that when there is a legacy table that we are still going to need for SROC. We are going to create a View of that table in the `public` schema and correct any issues with naming conventions, unused fields etc in the view. The first of these views that represent the old `returns` tables have been created in #531 This PR will create the models, helpers and unit tests required to be able to start to use these new views.
Jozzey
added
the
housekeeping
When building our views we are only pulling across data that is actually used. There is data in the `returns` and `lines` tables that is not used but is Not Nullable. We are therefore setting a default value for these fields rather than add useless data to our views which we then have to keep populating.
Cruikshanks
requested changes
Nov 23, 2023
Cruikshanks
approved these changes
Nov 23, 2023
Jozzey
added a commit
that referenced
this pull request
Dec 6, 2023
https://eaflood.atlassian.net/browse/WATER-4057 As part of the work we have been doing on two-part tariff, we will be creating all our new tables in the default `public` schema. We have also decided that when there is a legacy table that we are still going to need we will create a [View](https://www.postgresql.org/docs/current/sql-createview.html) of it in the `public` schema. This allows us to correct any issues with naming conventions, strip out unused fields, and join entities currently sat in different schemas. The first example of this approach was done in PR #531 in which views were created for the RETURNS schema. We then created the new models and helpers that use them in [Build models for returns based on new Views](#533). This is the final step in the process, we are refactoring any use of the legacy models to use the new ones and deleting all the legacy-based code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#106
As part of the work we have been doing to get migrations working in water-abstraction-system we are going to be creating all our new tables in a single schema
public.We have also decided that when there is a legacy table that we are still going to need for SROC. We are going to create a View of that table in the
publicschema and correct any issues with naming conventions, unused fields etc in the view. The first of these views that represent the oldreturnstables have been created in #531This PR will create the models, helpers and unit tests required to be able to start to use these new views.