Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Select the start date (return requirements) #574

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

robertparkinson
Copy link
Collaborator

https://eaflood.atlassian.net/browse/WATER-4249

We are starting work on adding support for setting up return requirements within the service. A return requirement sets out how a licensee is expected to submit their returns, for example, daily, weekly or monthly, by what date, and using what unit of measure.

This is the second page in the return requirements setup journey when 'no returns required' is selected.

This is just a stub page and controls and validation will come later.

https://eaflood.atlassian.net/browse/WATER-4249

We are starting work on adding support for setting up return requirements within the service. A return requirement sets out how a licensee is expected to submit their returns, for example, daily, weekly or monthly, by what date, and using what unit of measure.

This is the second  page in the return requirements setup journey when 'no returns required' is selected.

This is just a stub page and controls and validation will come later.
@Cruikshanks Cruikshanks added the enhancement New feature or request label Dec 7, 2023
@Cruikshanks
Copy link
Member

@robertparkinson robertparkinson marked this pull request as ready for review December 11, 2023 15:44
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just got one small request about sticking a module declaration at the top of the file. Who knows, one day it might be useful! 😁

Other than that this is bang on. Welcome to the team! 👥

app/controllers/licences.controller.js Show resolved Hide resolved
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertparkinson robertparkinson merged commit eced6a6 into main Dec 12, 2023
6 checks passed
@robertparkinson robertparkinson deleted the add-select-start-date-page branch December 12, 2023 10:32
Beckyrose200 pushed a commit that referenced this pull request Dec 14, 2023
https://eaflood.atlassian.net/browse/WATER-4249

We are starting work on adding support for setting up return requirements within the service. A return requirement sets out how a licensee is expected to submit their returns, for example, daily, weekly or monthly, by what date, and using what unit of measure.

This is the second  page in the return requirements setup journey when 'no returns required' is selected.

This is just a stub page and controls and validation will come later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants