Set up session table (return requirements) #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4257 We need to store user journeys as people progress through the screens and we need a table to store these in.
Cruikshanks
requested changes
Dec 15, 2023
test/models/session.model.test.js
Outdated
| // Thing under test | ||
| const SessionModel = require('../../app/models/session.model.js') | ||
|
|
||
| describe('Sessions model', () => { |
There was a problem hiding this comment.
Suggested change
| describe('Sessions model', () => { | |
| describe('Session model', () => { |
Comment on lines
39
to
42
| const defaults = { | ||
| id: generateUUID(), | ||
| data: {} | ||
| } |
There was a problem hiding this comment.
Where a table automatically generates an ID we don't tend to set one in the helper. If you've seen us do this it should normally come with a note saying the previous team failed to implement an automatic UUID on insert in the underlying table, hence the need to do it.
So, we just focus on setting meaningful defaults to reflect what an instantiated record would typically look like.
In this particular case data: {} could be what we often find. So, I'd suggest one of the following, I'll leave you to decide which one to go with!
const defaults = {
data: { licenceId: '01/128' }
}Or whatever pretend test values you'd like to set in
data:
or
const defaults = {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4257
We need to store user journeys as people progress through the screens and we need a table to store these in.