Add controls & validation to rtn reqs reason page #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f 7) https://eaflood.atlassian.net/browse/WATER-4265 This is the second page in the returns required journey. This page will have radio control options. This page will have validation to ensure that the user has selected a radio option.
Demwunz
changed the title
Demwunz
changed the title
…quired-journey-select-return-reason-page-iteration-2-2-of-7
…quired-journey-select-return-reason-page-iteration-2-2-of-7
…quired-journey-select-return-reason-page-iteration-2-2-of-7
This commit adds controls for the 2nd step in the no returns required journey. It also has validation which checks to ensure a value is selected on the form
test had wrong data inside. fixed with correct data
Cruikshanks
force-pushed
the
WATER-4265-returns-required-journey-select-return-reason-page-iteration-2-2-of-7
branch
from
71620bd to
91a63da
Compare
…quired-journey-select-return-reason-page-iteration-2-2-of-7
Having completed the [Returns required journey - Select start date page iteration 2 (1 of 7)](#646) I was expecting the pattern implemented to follow that more than what we'd originally done for 'no-returns-required'. But with so few pages implemented with controls it's hard to see a pattern! So, that wasn't made clear enough. To help I've completed [Update no-returns-required to use submit service](#708) which updates the 'no-returns-required' page to follow the template laid out for 'start-date'. Essentially, validation and error handling will now be done in a `Submit[Page]Service` rather than reuse `[Page]Service`. And so again, I'll go through and contribute to this PR to highlight the changes and when possible, expand on the reasons why.
That was me! Doh!
This is slightly pre-emptive but we know we will need to handle persisting valid payloads to the sessions record soon. Having a service separate from what we call on the GET request gives us an appropriate place to put that. It also allows us to simplify the controller logic in the meantime.
Now handled by the submit service.
We'll never pass an error in now because we'll never call this in the POST handler.
Also bring it inline with no returns required and start date.
We changed the control to match the page and everything else so we need to update the validator to use the new reference.
As our unit test confirmed it was checking for a value but would accept any value. Now it will only accept certain values.
Now it is consistent with what we just did in the `ReasonValidator`.
Cruikshanks
changed the title
|
Adjusted the title to match our standards for PRs and what the final commit title will be.
|
|
With these changes in place @Demwunz I'd be happy to approve. But double-check what I've done in case you have any questions or concerns. |
|
Thanks for going through these @Cruikshanks |
Cruikshanks
approved these changes
Feb 5, 2024
…eturn-reason-page-iteration-2-2-of-7
Demwunz
deleted the
WATER-4265-returns-required-journey-select-return-reason-page-iteration-2-2-of-7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4265
This is the second page in the returns required journey.
This page will have radio control options.
This page will have validation to ensure that the user has selected a radio option.