Fix bill licences with no transactions in bill run #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4379 We are working to replace the legacy SROC annual billing engine with one in this project that exploits what we did with SROC supplementary billing. The first pass of testing has highlighted a discrepancy with the how many licences are bing included in some bills. For example, the legacy bill run will only display 1 but the new engine will display 3. When we looked into it we found it was because only 1 of the 3 licences had applicable transactions. Two of the licences had no billable days. The legacy is correct in this case, we shouldn't be creating bill licence records where there were no transactions. This change fixes the annual billing engine to deal with this scenario. > For reference the licences had no billable days because they were revoked before the abstraction period on the charge reference i.e. revoked before the charge period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4379
We are working to replace the legacy SROC annual billing engine with one in this project that exploits what we did with SROC supplementary billing.
The first pass of testing has highlighted a discrepancy with how many licences are being included in some bills. For example, the legacy bill run will only display 1 but the new engine will display 3.
When we looked into it we found it was because only 1 of the 3 licences had applicable transactions. Two of the licences had no billable days.
The legacy is correct in this case, we shouldn't be creating bill licence records where there were no transactions. This change fixes the annual billing engine to deal with this scenario.