Select agreements and exceptions for requirements #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4301 This is PR is focused on adding functionality to page 7 of 11 in the return requirement pages. The pages were previously setup as part of a separate PR to create the user journey.
… ReturnRequirements controller
…s" was the valid value in validator
…ttps://github.com/DEFRA/water-abstraction-system into return-requirements-select-agreement-and-exceptions
rvsiyad
requested review from
Jozzey and
Beckyrose200
and removed request for
Demwunz,
Cruikshanks,
robertparkinson,
Jozzey and
Beckyrose200
Cruikshanks
requested changes
Apr 28, 2024
app/services/return-requirements/submit-agreements-exceptions.service.js
Outdated
Show resolved
Hide resolved
app/validators/return-requirements/agreements-exceptions.validator.js
Outdated
Show resolved
Hide resolved
Cruikshanks
approved these changes
Apr 29, 2024
jonathangoulding
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Select agreements and exceptions for requirements https://eaflood.atlassian.net/browse/WATER-4301 This is PR is focused on adding functionality to page 7 of 11 in the return requirement pages. The pages were previously setup as part of a separate PR to create the user journey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4301
This is PR is focused on adding functionality to page 7 of 11 in the return requirement pages.
The pages were previously setup as part of a separate PR to create the user journey.