Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay submitted data with a validation error #956

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

rvsiyad
Copy link
Contributor

@rvsiyad rvsiyad commented Apr 30, 2024

This PR is focused on replaying submitted start dates with a validation error for page 1 in the return requirements journey.

When a user inputs an invalid start date that returns a validation error, the page will clear the input. This needs to be fixed so that data with errors is replayed to the user so they can make changes to what they have submitted.

When a user inputs data that returns a validation error, the page will clear the input.
This needs to be fixed so that data with errors is replayed to the user so they can make
changes to what they have submitted.

This PR is focused on replaying submitted data with a validation error.
@rvsiyad rvsiyad added enhancement New feature or request housekeeping Refactoring, tidying up or other work which supports the project labels Apr 30, 2024
@rvsiyad rvsiyad self-assigned this Apr 30, 2024
@rvsiyad rvsiyad requested review from Cruikshanks and Demwunz April 30, 2024 14:51
@rvsiyad rvsiyad marked this pull request as ready for review April 30, 2024 14:52
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request. Could you update the PR description/squashed commit message to specify which page we are doing this to? 🙇

@rvsiyad rvsiyad merged commit 6b47d9a into main Apr 30, 2024
6 checks passed
@rvsiyad rvsiyad deleted the return-requirements-replay-submitted-data branch April 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants