Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You are about to remove these return requirements #996

Merged
merged 30 commits into from
May 15, 2024

Conversation

rvsiyad
Copy link
Contributor

@rvsiyad rvsiyad commented May 9, 2024

https://eaflood.atlassian.net/browse/WATER-4304

During the return requirements journey, users are given the option to add more requirements to the returns. As a result, users need to have an option to remove a single requirement at a time.

This PR is focused on setting up the page and functionality for users to remove a single requirement.

https://eaflood.atlassian.net/browse/WATER-4304

During the return requirements journey, users are given the option to add more requirements to
the returns. As a result, users need to have an option to remove a single requirement at a time.

This PR is focused on setting up the page and functionality for users to remove a single requirement.
@rvsiyad rvsiyad added the enhancement New feature or request label May 9, 2024
@rvsiyad rvsiyad self-assigned this May 9, 2024
@rvsiyad rvsiyad marked this pull request as ready for review May 13, 2024 15:56
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor NITS and suggestions.

app/presenters/return-requirements/remove.presenter.js Outdated Show resolved Hide resolved
app/routes/return-requirement.routes.js Outdated Show resolved Hide resolved
app/services/return-requirements/submit-remove.service.js Outdated Show resolved Hide resolved
test/controllers/return-requirements.controller.test.js Outdated Show resolved Hide resolved
app/presenters/return-requirements/remove.presenter.js Outdated Show resolved Hide resolved
@rvsiyad rvsiyad requested a review from Cruikshanks May 15, 2024 10:26
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvsiyad rvsiyad merged commit 3227cc4 into main May 15, 2024
6 checks passed
@rvsiyad rvsiyad deleted the remove-return-requirement branch May 15, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants