Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a PSR in the example folder #6

Closed
jiweiqi opened this issue Feb 14, 2021 · 2 comments
Closed

Implement a PSR in the example folder #6

jiweiqi opened this issue Feb 14, 2021 · 2 comments
Assignees
@jiweiqi
Labels
enhancement New feature or request ready to close

Comments

@jiweiqi
Copy link
Contributor

jiweiqi commented Feb 14, 2021

For example
https://github.com/DENG-MIT/NN-PSR/blob/main/node_pyrolysis.jl
@jiweiqi jiweiqi self-assigned this Feb 14, 2021
@jiweiqi jiweiqi added the enhancement New feature or request label Feb 14, 2021
@jiweiqi
Copy link
Contributor Author

jiweiqi commented Feb 16, 2021

Example at
https://github.com/DENG-MIT/NN-PSR/blob/eb5b934fa9d5f6e9c75dbf2500988fd42e117703/PSR.jl#L1
https://github.com/DENG-MIT/NN-PSR/blob/main/PSR.jl

Validation with Cantera

PSR

@jiweiqi
Copy link
Contributor Author

jiweiqi commented Feb 23, 2021

Host the example in the separated repo is a good idea to keep this repo clean.

@jiweiqi jiweiqi closed this as completed Feb 23, 2021
jiweiqi added a commit that referenced this issue May 3, 2021
@jiweiqi
Merge pull request #6 from DENG-MIT/main
112dd93 
update from master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiweiqi jiweiqi

Labels
enhancement New feature or request ready to close
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiweiqi