Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized Thermo generation to enable Solution with arbitrary thermo #76

Merged
merged 1 commit into from
May 19, 2021

Conversation

TJP-Karpowski
Copy link
Contributor

Hi,

this pull-request is related to issue #72 . It creates the IdealGasThermo in a constructor which takes the yaml as input. Futhermore, metaprogramming directly enables the use of a changed thermo model from a mechanism. (mechanism-> phase-> thermo: MyGas dispatches to MyGasThermo(yaml).)

A simillar structure could be used for kinetics and transport to make Arrhenius more modular. The thermomodel could also be constructed from the yaml file outside of CreateSolution.

Copy link
Contributor

@jiweiqi jiweiqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice! Indeed, modularity will be very useful when more physics is included.

@jiweiqi jiweiqi merged commit 9f29290 into DENG-MIT:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants