Bulk unsubscribe Candidates in Support #10228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcyoung-dev
force-pushed
the
import-unsubscribed-email-addresses
branch
from
e529ad8 to
250b962
Compare
dcyoung-dev
force-pushed
the
import-unsubscribed-email-addresses
branch
from
250b962 to
c2c147f
Compare
dcyoung-dev
force-pushed
the
import-unsubscribed-email-addresses
branch
from
f16dee0 to
26ee4ba
Compare
|
Trello: https://trello.com/c/R8vZn7iE |
Added a Bulk Unsubscribe Form Added a Bulk Unsubscribe Worker Added a Bulk Unsubscribe Service Unsubscribing is performed by `update_all` in batches to ensue performance
dcyoung-dev
force-pushed
the
import-unsubscribed-email-addresses
branch
from
26ee4ba to
de11e6c
Compare
elceebee
reviewed
Jan 9, 2025
| .split("\n") | ||
| .map(&:strip) | ||
| .compact_blank | ||
| Support::Candidates::BulkUnsubscribeWorker.perform_async(unsubscribe_email_addresses) |
There was a problem hiding this comment.
Presumably we are doing this async because we are anticipating putting A LOT of email addresses in the box? Just wondering.
There was a problem hiding this comment.
Yeah future proofing to be honest - currently we have about 14 to do. My thoughts were that this sets us up to handle bulk through an API - that'd be ideal
elceebee
reviewed
Jan 9, 2025
Renames `.erb-lint.yml` to `.erb_lint.yml` as suggested in [lint failures](https://github.com/DFE-Digital/apply-for-teacher-training/actions/runs/12693098266/job/35381314500?pr=10228) >The config file has been renamed to `.erb_lint.yml` and `.erb-lint.yml` is deprecated. Please rename your config file to `.erb_lint.yml`.
elceebee
reviewed
Jan 10, 2025
| require 'rails_helper' | ||
|
|
||
| RSpec.describe SupportInterface::Candidates::BulkUnsubscribe do | ||
| describe '.bulk_unsubscribe' do |
There was a problem hiding this comment.
Could we add a test that shows if an email address is included that doesn't actually belong to a candidate, it doesn't break the job?
I'm thinking of the scenario where a candidate changes their email address between clicking the unsubscribe button via notify and someone running this job.
dcyoung-dev
temporarily deployed
to
review_aks
GitHub Actions
Inactive
elceebee
reviewed
Jan 10, 2025
| expect(candidate2.reload).to be_unsubscribed_from_emails | ||
| end | ||
|
|
||
| it 'can handle unknown email addresses' do |
elceebee
approved these changes
Jan 10, 2025
dcyoung-dev
temporarily deployed
to
review_aks
GitHub Actions
Inactive
dcyoung-dev
temporarily deployed
to
review_aks
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When users unsubscribe from bespoke Notify emails, their email address is exportable from the Notify service and does not automatically unsubscribe them from emails in Apply.
Manual intervention is required to export these email addresses from Notify and update the Candidate in Apply, this PR aims to provide an interface in the Support Console to enable us to update Candidates unsubscribe preferences.
Changes proposed in this pull request
New UI
Screen.Recording.2025-01-09.at.15.16.15.mov
Guidance to review
Things to check