Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[545] Remove feature flag uses throughout #10232

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jan 9, 2025

Context

trello: https://trello.com/c/0ZWcB3K9

This is the first part of a clean up task to remove the feature flag and old withdraw routes and views once the feature has been fully released.

The second PR, here, will remove the feature flag from the database.

Neither PR should be merged until the feature flag has been activated (plan to activate on 13 Jan, so this can be merged in a few days after that if all is going well)

Changes proposed in this pull request

  • Removes feature flag uses
  • Updates tests
  • Removes views / routes that are no longer in use

Guidance to review

Any missing test coverage / unintended consequences?

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee force-pushed the 545-remove-feature-flag-and-old-withdrawal-routes branch from 1908f5e to 9d7f144 Compare January 9, 2025 17:32
@elceebee elceebee force-pushed the 545-remove-feature-flag-and-old-withdrawal-routes branch from 9d7f144 to 011bb48 Compare January 9, 2025 17:33
@elceebee elceebee force-pushed the 545-remove-feature-flag-and-old-withdrawal-routes branch from 011bb48 to f303319 Compare January 10, 2025 09:36
@elceebee elceebee force-pushed the 545-remove-feature-flag-and-old-withdrawal-routes branch from f303319 to 13d2608 Compare January 10, 2025 09:54
@elceebee elceebee changed the title Remove feature flag uses throughout [545] Remove feature flag uses throughout Jan 10, 2025
@elceebee elceebee self-assigned this Jan 10, 2025
@elceebee elceebee force-pushed the 545-remove-feature-flag-and-old-withdrawal-routes branch from 13d2608 to 6338794 Compare January 10, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant