Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API tokens page #10243

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Improve API tokens page #10243

wants to merge 5 commits into from

Conversation

dcyoung-dev
Copy link
Collaborator

@dcyoung-dev dcyoung-dev commented Jan 10, 2025

Context

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

Sorts tokens based on the Last Used At attribute with tokens that have not been used being at the bottom of the list.
Originally a token was created from the list view, this has been moved to a dedicated `new` page
Now uses a form object with error handling
Page title added with error prefix in title
@dcyoung-dev
Copy link
Collaborator Author

Trello: https://trello.com/c/ptYXsMAR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant