[CAPT-1797] Ops reports #3284

alkesh · 2024-10-08T09:43:44Z

new nav bar entry on the admin site: Reports
reports page shows previously ran reports
reports stored in database
ReportsJob set to run on second Tuesday of each month
Report classes based on the existing Claim::DataReportRequest class

rjlynch

Looks good to me - would check with @slorek and see if this fits with his design for the app

app/models/reports/duplicate_claims.rb

app/models/reports/failed_provider_check_claims.rb

app/models/reports/failed_qualification_claims.rb

db/migrate/20241007141638_create_reports.rb

Getting this spike pr in shape, first step is adding some feature specs.

Some tweaks to the spike code to get this working, we need to handle the eligibility not having an eligibile itt subject, and we also want to scope the claims we're looking at to the current academic year.

Some tweaks to the spike code for this report and adds a test.

Adds a test and fixes up the csv code as not all claims will have a teacher_reference_number

Pull out a claim presenter to match how the other reports work. This will also give us somewhere to store presentation logic if we need any more.

Slightly reduce the number of claims we need to check!

Don't need to stub the duplciates, pretty straightforward to set up a basic duplicate scenario.

Even if this claim doesn't have duplicates we still access the eligibility as part of the matching attribute checking code (to grab thhe policy), so it's worth eager loading.

Adds a button to the report page

Greatly speeds up the duplicate checking

We don't need to keep old reports around so there's no need to generate a new report each time the job runs.

Limiting the duplicate claims checking to unpaid claims only the reporting can be run everyday as it's pretty quick (sub one minute).

rjlynch · 2025-01-16T15:03:21Z

I've decided to use the background job based approach in this spike pr and have cleaned up this PR so it's good to review.
The reports don't need to be live so a background job generating them daily is fine (can be less frequent).
I think the Report model / storing the CSV in a column on the model (the approach taken in the spike) is a good idea, v simple and does the job.

I've profiled the duplicate claim report against the production database.
Checking all approved claims for duplicates takes ~9minutes to run, which isn't bad for a background job.
Checking only approved unpaid claims takes ~11 seconds which is fine for a background job task.
Speaking with Dan, the main use of the duplicate claims report will be a final sense check before payroll so filtering out paid claims from this report seems fine. (The unpaid claims we're checking are checked against paid claims for duplicates)

alkesh force-pushed the CAPT-1797-monthly-reports branch from d00e400 to 5247399 Compare October 8, 2024 09:46

rjlynch approved these changes Oct 8, 2024

View reviewed changes

slorek added the Do not merge label Nov 8, 2024

rjlynch force-pushed the CAPT-1797-monthly-reports branch 2 times, most recently from 5f9a97f to ccf6dc2 Compare January 14, 2025 16:55

rjlynch removed the Do not merge label Jan 15, 2025

alkesh and others added 2 commits January 16, 2025 12:11

initial spike

fe9a773

Add feature specs

88b0cac

Getting this spike pr in shape, first step is adding some feature specs.

rjlynch force-pushed the CAPT-1797-monthly-reports branch from 8f20409 to f5f6dbc Compare January 16, 2025 12:11

rjlynch changed the title ~~[CAPT-1797] Ops reports spike~~ [CAPT-1797] Ops reports Jan 16, 2025

rjlynch added 11 commits January 16, 2025 14:25

Fix up failed qualification claims

b79b03f

Some tweaks to the spike code to get this working, we need to handle the eligibility not having an eligibile itt subject, and we also want to scope the claims we're looking at to the current academic year.

Fix up failed provider check report

6556579

Some tweaks to the spike code for this report and adds a test.

Fix up spike

fdad326

Adds a test and fixes up the csv code as not all claims will have a teacher_reference_number

Use a claim presenter

bbcffcf

Pull out a claim presenter to match how the other reports work. This will also give us somewhere to store presentation logic if we need any more.

Limit claims to just those in the current year

4f83038

Slightly reduce the number of claims we need to check!

Use real duplicate mechanism

2b867f8

Don't need to stub the duplciates, pretty straightforward to set up a basic duplicate scenario.

Eager load eligibility

4375d34

Even if this claim doesn't have duplicates we still access the eligibility as part of the matching attribute checking code (to grab thhe policy), so it's worth eager loading.

Add button to claim index

10c03e0

Adds a button to the report page

Only check unpaid claims

00bd2d3

Greatly speeds up the duplicate checking

Don't generate multiple reports

b5ff5bf

We don't need to keep old reports around so there's no need to generate a new report each time the job runs.

Run report job daily

1690825

Limiting the duplicate claims checking to unpaid claims only the reporting can be run everyday as it's pretty quick (sub one minute).

rjlynch force-pushed the CAPT-1797-monthly-reports branch from f5f6dbc to 1690825 Compare January 16, 2025 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CAPT-1797] Ops reports #3284

[CAPT-1797] Ops reports #3284

alkesh commented Oct 8, 2024 •

edited

Loading

rjlynch left a comment

rjlynch commented Jan 16, 2025 •

edited

Loading

[CAPT-1797] Ops reports #3284

Are you sure you want to change the base?

[CAPT-1797] Ops reports #3284

Conversation

alkesh commented Oct 8, 2024 • edited Loading

rjlynch left a comment

Choose a reason for hiding this comment

rjlynch commented Jan 16, 2025 • edited Loading

alkesh commented Oct 8, 2024 •

edited

Loading

rjlynch commented Jan 16, 2025 •

edited

Loading