Skip to content

Commit

Permalink
No need for completed
Browse files Browse the repository at this point in the history
All information must be filled out (even if not applicable)
  • Loading branch information
ebrett committed Nov 10, 2022
1 parent 9266f6f commit f278ad7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
5 changes: 0 additions & 5 deletions spec/factories/users.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@
terms_and_conditions_agreed_at { Date.new(2000, 0o1, 0o1) }
end

trait :completed do
registered
ofsted_number { 'EY123456' }
end

trait :name do
first_name { Faker::Name.first_name }
last_name { Faker::Name.last_name }
Expand Down
6 changes: 3 additions & 3 deletions spec/support/shared/with_events.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
RSpec.shared_context 'with events' do
let(:user) { create(:user, :completed) }
let(:user1) { create(:user, :completed) }
let(:user2) { create(:user, :completed) }
let(:user) { create(:user, :registered) }
let(:user1) { create(:user, :registered) }
let(:user2) { create(:user, :registered) }

let(:events) do
Ahoy::Event.where(user_id: user.id).where_properties(training_module_id: module_name)
Expand Down
4 changes: 2 additions & 2 deletions spec/system/whats_new_page_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
include_context 'with user'

context 'when existing user' do
let(:user) { create :user, :completed, :display_whats_new }
let(:user) { create :user, :registered, :display_whats_new }

context "and 'whats new' page has not been viewed" do
it "visits what's new page after sign in" do
Expand All @@ -13,7 +13,7 @@
end

context "and 'whats new' page has been viewed" do
let(:user) { create :user, :completed, :display_whats_new }
let(:user) { create :user, :registered, :display_whats_new }

it "does not visit what's new page after sign in" do
click_on 'Sign out'
Expand Down

0 comments on commit f278ad7

Please sign in to comment.