Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump govuk_design_system_formbuilder from 3.1.2 to 3.2.0 #374

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2022

Bumps govuk_design_system_formbuilder from 3.1.2 to 3.2.0.

Release notes

Sourced from govuk_design_system_formbuilder's releases.

Version 3.2.0

  • Fix a bug where classes passed in via label/hint/legend/caption hashes replaced the defaults rather than appending to them #397 - thanks @​cpjmcquillan
  • Update supported Rails versions to 6.1.7 and 7.0.4 #387
  • Update supported GOV.UK frontend version to 4.3.1 #387
  • Stop using official assets in the guide #388
  • Fix the exclusive checkboxes example in the guide #391 - thanks @​c0nspiracy
  • Improve the contrast in code snippets in the guide and fix a minor display bug #392, #393
  • Add a CodeQL scanning workflow task f9379fb2f

Upgrade notes

When passing additional custom classes in via label, caption, hint or legend hashes they are added to the default class rather than overwriting it. This brings the behaviour in line with the rest of the library and considered a bug fix rather than a breaking change.

Given the input:

f.govuk_text_area :details, label: { text: "Some details", class: "special-class" }

Output before this release

<label for="model-details-field" class="special-class">Some details</label>

Output after this release

<label for="model-details-field" class="govuk-label special-class">Some details</label>
Commits
  • 7b20630 Release version 3.2.0
  • f9379fb Add CodeQL scanning
  • 0f5a1c5 Merge pull request #397 from DFE-Digital/cm/label-html-classes
  • 63ae6b8 Append custom classes to hints, legends, captions
  • b72c3c1 Append custom custom classes to labels
  • eaf8905 Merge pull request #395 from DFE-Digital/dependabot/bundler/rubocop-govuk-tw-...
  • 556985f Update rubocop-govuk requirement from ~> 4.7.0 to ~> 4.8.0
  • 25e0866 Merge pull request #394 from DFE-Digital/dependabot/bundler/rspec-rails-tw-6.0
  • 8a6683e Update rspec-rails requirement from ~> 5.0 to ~> 6.0
  • 3e2528a Merge pull request #393 from DFE-Digital/stop-code-block-css-obscuring-next-line
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Nov 13, 2022
@viezly
Copy link

viezly bot commented Nov 13, 2022

Pull request by bot. No need to analyze

@peterdavidhamilton
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 14, 2022

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@peterdavidhamilton
Copy link
Contributor

@dependabot recreate

Bumps [govuk_design_system_formbuilder](https://github.com/DFE-Digital/govuk-formbuilder) from 3.1.2 to 3.2.0.
- [Release notes](https://github.com/DFE-Digital/govuk-formbuilder/releases)
- [Commits](x-govuk/govuk-form-builder@v3.1.2...v3.2.0)

---
updated-dependencies:
- dependency-name: govuk_design_system_formbuilder
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/govuk_design_system_formbuilder-3.2.0 branch from f68ba50 to 6b438da Compare November 14, 2022 06:57
@peterdavidhamilton peterdavidhamilton temporarily deployed to test November 14, 2022 07:04 Inactive
@peterdavidhamilton peterdavidhamilton added this to the Not released milestone Nov 14, 2022
@peterdavidhamilton peterdavidhamilton merged commit 1d3c805 into main Nov 14, 2022
@peterdavidhamilton peterdavidhamilton temporarily deployed to production November 14, 2022 07:11 Inactive
@peterdavidhamilton peterdavidhamilton deleted the dependabot/bundler/govuk_design_system_formbuilder-3.2.0 branch November 14, 2022 07:11
@peterdavidhamilton peterdavidhamilton modified the milestones: Not released, v0.1.2 release Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant