Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple callbacks rack #427

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

tavyy
Copy link
Contributor

@tavyy tavyy commented Jan 16, 2020

Context

We want to build the redirect_uri in Omniauth ideally dynamically by parsing the requests at the rack level.

Check: https://github.com/omniauth/omniauth/blob/c2380ae848ce4e0e39b4bb94c5b8e3fd0a544825/lib/omniauth/strategy.rb to understand how that's done.
omniauth/omniauth-oauth2#93
https://docs.microsoft.com/en-us/graph/tutorials/ruby?tutorial-step=3

We also leave the option to explicitly set the redirect_uri as options.

This will allow us to have multiple callback urls setup in Azure AD.

@cwrw cwrw temporarily deployed to get-help-to-allow-multi-obcdv9 January 16, 2020 14:43 Inactive
@tavyy tavyy force-pushed the allow-multiple-callbacks-rack branch from 43f02c7 to e6054cf Compare January 16, 2020 14:48
@cwrw cwrw temporarily deployed to get-help-to-allow-multi-obcdv9 January 16, 2020 14:48 Inactive
@cwrw cwrw temporarily deployed to get-help-to-allow-multi-ygiprh January 16, 2020 14:59 Inactive
@cwrw cwrw temporarily deployed to get-help-to-allow-multi-ygiprh January 16, 2020 15:14 Inactive
@tavyy tavyy force-pushed the allow-multiple-callbacks-rack branch from 7e61fb3 to e6054cf Compare January 16, 2020 16:45
@cwrw cwrw temporarily deployed to get-help-to-allow-multi-ygiprh January 16, 2020 16:46 Inactive
@tavyy tavyy marked this pull request as ready for review January 16, 2020 17:03
Copy link
Contributor

@cwrw cwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tavyy tavyy merged commit dd8a3e2 into master Jan 17, 2020
@tavyy tavyy deleted the allow-multiple-callbacks-rack branch January 17, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants