Make the open schools request spec dynamic #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteryates
commented
Sep 2, 2023
|
|
||
| RSpec.describe 'GET /open_schools' do | ||
| let(:open_school_count) do | ||
| CSV | ||
| .read(Dir.glob('tmp/*test-set*').pop, headers: true) |
There was a problem hiding this comment.
I wonder if just hardcoding some test data is better here. This clearly isn't the most robust thing ever written 🙈
peteryates
force-pushed
the
make-open-schools-request-spec-dynamic
branch
from
e9dc7f7 to
ee94923
Compare
duncanjbrown
approved these changes
Sep 5, 2023
This test started failing because the number of open schools seems to have changed from 81 to 80. Here, it's not the number that's important but that the number matches the quantity in the test set.
peteryates
force-pushed
the
make-open-schools-request-spec-dynamic
branch
from
ee94923 to
1750671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing because the number of open schools seems to have changed from 81 to 80. Here, it's not the number that's important but that the number matches the quantity in the test set.